-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICS Generator tool update #30866
Merged
mergify
merged 24 commits into
project-chip:master
from
ReneJosefsen:rjosefsen/PICS-generator-fixes
Mar 6, 2024
Merged
PICS Generator tool update #30866
mergify
merged 24 commits into
project-chip:master
from
ReneJosefsen:rjosefsen/PICS-generator-fixes
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
December 7, 2023 09:06
PR #30866: Size comparison from c48a435 to 16c5533 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30866: Size comparison from 9bde938 to 123d2eb Decreases (1 build for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
fessehaeve
approved these changes
Jan 30, 2024
fessehaeve
reviewed
Jan 30, 2024
Survensa
approved these changes
Feb 6, 2024
PR #30866: Size comparison from 355e2b4 to 6637036 Decreases (3 builds for efr32)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
PR #30866: Size comparison from 355e2b4 to c083d96 Decreases (3 builds for efr32)
Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
cecille
approved these changes
Feb 28, 2024
PR #30866: Size comparison from 355e2b4 to 5e2d169 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #30866: Size comparison from 04d7a3e to 4bb5e1b Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
arkq
approved these changes
Mar 6, 2024
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Mar 7, 2024
* Fixed missed cluster renaming and adjusted output folder behavior * Minor adjustments to readme to match the proper location of tool * Fix restyle * Reverted laundry mode due to rename revert * Fully remove laundry mode cluster handling * Use DM XML for PICS code rather than cluster data file * Remove unused import * Remove uncommented code * Update special cluster handling and fixed crash when node is not present in PICS XML * Added special handling for Laundry clusters * Improved handling for non standard clusters * Updated handling for special cluster names * Updated Access Control handling * Remove space in AccessControl * Added handling for ICDManagement * Fix bug in if statement syntax * Minor updates to match spring 2024 SVE PICS
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
* Fixed missed cluster renaming and adjusted output folder behavior * Minor adjustments to readme to match the proper location of tool * Fix restyle * Reverted laundry mode due to rename revert * Fully remove laundry mode cluster handling * Use DM XML for PICS code rather than cluster data file * Remove unused import * Remove uncommented code * Update special cluster handling and fixed crash when node is not present in PICS XML * Added special handling for Laundry clusters * Improved handling for non standard clusters * Updated handling for special cluster names * Updated Access Control handling * Remove space in AccessControl * Added handling for ICDManagement * Fix bug in if statement syntax * Minor updates to match spring 2024 SVE PICS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a series of missed cluster renaming required to map from python naming to the XML template files.
This PR also adjusts the output folder behavior, given it causes an unintentional issue of cleaning all files in the passed in folder, if present, which is not ideal.